BewareMyPower commented on PR #23298: URL: https://github.com/apache/pulsar/pull/23298#issuecomment-2348455992
I swallowed the exception in `BrokerRegistryImpl#unregister()`. BTW, I think all synchronous close operations for components should not throw any exception. Otherwise, the following close operations will be skipped. Just add error logs for unexpected exceptions and warning logs for expected exceptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
