heesung-sn commented on PR #23349:
URL: https://github.com/apache/pulsar/pull/23349#issuecomment-2375173020
Thank you for taking a loot at this issue.
For the last broker shutdown issue,
I think we have two options:
1. set all ownerships to Free and shutdown
This can be a little tricky because the clients could trigger lookups and
new assignments might happen during shutdown. We can introduce a state to fail
assignment during shutdown.
2. skip the gracefulShutdown and just shutdown loadManager.
Since there is no broker available to transfer ownerships, we could just
simply shutdown the last broker -- since the load balancer is shutdown, no new
assignment will happen during shutdown.
When the fist broker(leader) starts, it will fix any orphan ones.
Seems like this pr is moving to the option 1.
Regarding the skip message issue,
I think the current skip logic can return lookups too soon, and I dont see a
good reason to keep it. For example, when there are concurrent Assign events,
it could return deferred lookups too soon by the skip msg logic, before Own
event. I think it can just wait for the final Own event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
