heesung-sn commented on code in PR #23349:
URL: https://github.com/apache/pulsar/pull/23349#discussion_r1775957883
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -774,7 +774,11 @@ brokerId, getLogEventTag(data), serviceUnit,
}
}
- private void handleSkippedEvent(String serviceUnit) {
+ private void handleSkippedEvent(String serviceUnit, ServiceUnitStateData
skippedData) {
+ if (skippedData.state() == Free) {
Review Comment:
This is risky as the skipped message impacts the current states - this Free
state can come from normal unload too.
The channel design principle is that only non-skipped messages should impact
the states in this channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
