lhotari commented on code in PR #23600:
URL: https://github.com/apache/pulsar/pull/23600#discussion_r1848141394
##########
pulsar-client-all/pom.xml:
##########
@@ -206,6 +206,7 @@
<include>org.tukaani:xz</include>
<!-- Issue #6834, Since Netty ByteBuf shaded, we need also
shade this module -->
<include>org.apache.pulsar:pulsar-client-messagecrypto-bc</include>
+ <include>it.unimi.dsi:*</include>
Review Comment:
This isn't the correct solution for shading fastutil. Please see
https://github.com/apache/pulsar/pull/23600/files#r1848136065
##########
pulsar-client-shaded/pom.xml:
##########
@@ -168,6 +168,7 @@
<include>org.tukaani:xz</include>
<!-- Issue #6834, Since Netty ByteBuf shaded, we need also
shade this module -->
<include>org.apache.pulsar:pulsar-client-messagecrypto-bc</include>
+ <include>it.unimi.dsi:*</include>
Review Comment:
This isn't the correct solution for shading fastutil. Please see
https://github.com/apache/pulsar/pull/23600/files#r1848136065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
