lhotari commented on code in PR #23600:
URL: https://github.com/apache/pulsar/pull/23600#discussion_r1848136065


##########
pulsar-client/pom.xml:
##########
@@ -207,6 +207,16 @@
       <scope>test</scope>
     </dependency>
 
+    <dependency>
+      <groupId>org.roaringbitmap</groupId>
+      <artifactId>RoaringBitmap</artifactId>
+    </dependency>
+
+    <dependency>
+      <groupId>it.unimi.dsi</groupId>
+      <artifactId>fastutil</artifactId>
+    </dependency>

Review Comment:
   This comment cannot be marked resolved before this is really addressed.
   
   Due to the large size of both fastutil (23MB) and fastutil-core (6MB), It is 
necessary to add a new module that minimizes fastutil for the use of the shaded 
Pulsar client (in published pulsar-client and pulsar-client-all modules). The 
minimized fastutil module shouldn't be published to maven central at all, but 
it is necessary to make it a separate module since it's not possible to 
selectively minimize modules with the maven-shade-plugin. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to