thetumbled commented on code in PR #23600:
URL: https://github.com/apache/pulsar/pull/23600#discussion_r1849842973
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConsumerConfigurationData.java:
##########
@@ -155,6 +155,16 @@ public class ConsumerConfigurationData<T> implements
Serializable, Cloneable {
)
private long negativeAckRedeliveryDelayMicros =
TimeUnit.MINUTES.toMicros(1);
+ @ApiModelProperty(
+ name = "negativeAckPrecisionBitCnt",
+ value = "The redelivery time precision bit count. The lower bits
of the redelivery time will be"
+ + "trimmed to reduce the memory occupation.\nThe default
value is 8, which means the"
+ + "redelivery time will be bucketed by 256ms, the
redelivery time could be earlier(no later)"
+ + "than the expected time, but no more than 256ms. \nIf
set to k, the redelivery time will be"
+ + "bucketed by 2^k ms.\nIf the value is 0, the redelivery
time will be accurate to ms."
+ )
+ private int negativeAckPrecisionBitCnt = 8;
Review Comment:
I suggest to configure it as the best the confguration value. Without this
enhancement, it is unrealistic to use negative acknowledgement in production.
The memory occupation will inflate very fast.
But i will listen to the voice from the community, if more and more people
think that disabling this feature by default is better, i will update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
