eolivelli commented on code in PR #23903:
URL: https://github.com/apache/pulsar/pull/23903#discussion_r1932236253
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/RangeCache.java:
##########
@@ -106,7 +106,7 @@ K getKey() {
return localKey;
}
- V getValue(K key) {
+ V getValue(K key, boolean requireSameKeyInstance) {
Review Comment:
what about adding a second method that is more lenient instead of increasing
the complexity of the existing ?
this is called on the hot paths, I think that it is worth to add some code
duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
