lhotari commented on code in PR #23903:
URL: https://github.com/apache/pulsar/pull/23903#discussion_r1932373250
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/RangeCache.java:
##########
@@ -106,7 +106,7 @@ K getKey() {
return localKey;
}
- V getValue(K key) {
+ V getValue(K key, boolean requireSameKeyInstance) {
Review Comment:
I found the issue in my test. One detail of the current broker cache
implementation is that it is necessary to configure
`cacheEvictionByMarkDeletedPosition=true` so that cached entries don't get
evicted by the read position in the managed ledger. I'll submit the test soon
with the changes to address this review comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
