lhotari commented on code in PR #23903:
URL: https://github.com/apache/pulsar/pull/23903#discussion_r1932251020
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/RangeCache.java:
##########
@@ -106,7 +106,7 @@ K getKey() {
return localKey;
}
- V getValue(K key) {
+ V getValue(K key, boolean requireSameKeyInstance) {
Review Comment:
Thanks, I'll address that soon.
btw. I'm currently working on adding a higher level Key_Shared test case
that reproduces the issue. I already have the test, but I'm not yet
understanding the reasons why the BK cache gets by passed also with this fix
included, so there must be some other issues involved in the use for broker
cache for replay queue reads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]