heesung-sn commented on code in PR #23903:
URL: https://github.com/apache/pulsar/pull/23903#discussion_r1932654980
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/RangeCache.java:
##########
@@ -116,7 +148,11 @@ V getValue(K key) {
localValue = this.value;
lock.unlockRead(stamp);
}
- if (localKey != key) {
+ // check that the given key matches the key associated with the
value in the entry
Review Comment:
What happens when this.key and this.value are recycled and have a new value
for the same key, after this line? Are we ok to return the old value here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
