codelipenghui commented on code in PR #24178:
URL: https://github.com/apache/pulsar/pull/24178#discussion_r2057428834
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/GeoReplicationProducerImpl.java:
##########
@@ -108,6 +108,15 @@ private void ackReceivedReplicatedMsg(ClientCnx cnx,
OpSendMsg op, long sourceLI
if (pendingLId != null && pendingEId != null
&& (pendingLId < lastPersistedSourceLedgerId ||
(pendingLId.longValue() == lastPersistedSourceLedgerId
&& pendingEId.longValue() <= lastPersistedSourceEntryId))) {
+ if
(MessageImpl.SchemaState.Broken.equals(op.msg.getSchemaState())) {
+ log.error("[{}] [{}] Replication is paused because the schema
is incompatible with the remote"
+ + " cluster, please modify the schema
compatibility for the remote cluster."
+ + " Latest published entry {}:{}, Entry who
has broken schema: {}:{},"
Review Comment:
Is it better to add a metric or is there any existing metrics for
replication failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
