blankensteiner commented on code in PR #263:
URL: https://github.com/apache/pulsar-dotpulsar/pull/263#discussion_r2092577229
##########
src/DotPulsar/Internal/SubConsumer.cs:
##########
@@ -237,4 +237,18 @@ private async ValueTask
InternalAcknowledge(IEnumerable<MessageId> messageIds, C
public ValueTask<IEnumerable<MessageId>>
GetLastMessageIds(CancellationToken cancellationToken = default) =>
throw new NotImplementedException();
+
+ public async ValueTask NegativeAcknowledge(MessageId messageId,
CancellationToken cancellationToken)
+ {
+ var command = new CommandRedeliverUnacknowledgedMessages();
Review Comment:
We already have 'RedeliverUnacknowledgedMessages' on the IConsumer that does
this. I haven't used negative acknowledge, but isn't it a client-side feature
to have the same message delivered again in a specified TimeSpan? Meaning no
interaction with the broker and enabling the user to set the TimeSpan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
