blankensteiner commented on code in PR #263:
URL: https://github.com/apache/pulsar-dotpulsar/pull/263#discussion_r2099620997


##########
src/DotPulsar/Internal/SubConsumer.cs:
##########
@@ -237,4 +237,18 @@ private async ValueTask 
InternalAcknowledge(IEnumerable<MessageId> messageIds, C
 
     public ValueTask<IEnumerable<MessageId>> 
GetLastMessageIds(CancellationToken cancellationToken = default) =>
         throw new NotImplementedException();
+
+    public async ValueTask NegativeAcknowledge(MessageId messageId, 
CancellationToken cancellationToken)
+    {
+        var command = new CommandRedeliverUnacknowledgedMessages();

Review Comment:
   We have two 'RedeliverUnacknowledgedMessages' methods. One to redeliver all 
and one where you can specify the messageIds you want redelivered?
   
https://github.com/apache/pulsar-dotpulsar/blob/e2025a0b61056b81c23cfb73e7f750fd554f3977/src/DotPulsar/Abstractions/IConsumer.cs#L62-L70



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to