ivan-ciklum commented on code in PR #263:
URL: https://github.com/apache/pulsar-dotpulsar/pull/263#discussion_r2095653152
##########
src/DotPulsar/Internal/SubConsumer.cs:
##########
@@ -237,4 +237,18 @@ private async ValueTask
InternalAcknowledge(IEnumerable<MessageId> messageIds, C
public ValueTask<IEnumerable<MessageId>>
GetLastMessageIds(CancellationToken cancellationToken = default) =>
throw new NotImplementedException();
+
+ public async ValueTask NegativeAcknowledge(MessageId messageId,
CancellationToken cancellationToken)
+ {
+ var command = new CommandRedeliverUnacknowledgedMessages();
Review Comment:
While it is true that RedeliverUnacknowledgedMessages already exists in
IConsumer, implementing NegativeAcknowledge can provide value from the client's
point of view, since it allows handling cases where you want to redeliver a
specific message in a more granular way, similar to what other Pulsar clients
offer.
This approach can be useful, for example, when the processing of a message
fails for a specific reason and you want to retry it without affecting the rest
of the unacknowledged messages.
I believe that offering both options provides flexibility and can make life
easier for those who integrate DotPulsar into their solutions. Do you see any
disadvantages in keeping both functionalities?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
