Jennifer88huang commented on a change in pull request #5052: [doc] Improve 
Pulsar Security-token-admin
URL: https://github.com/apache/pulsar/pull/5052#discussion_r319390326
 
 

 ##########
 File path: site2/docs/security-token-admin.md
 ##########
 @@ -6,96 +6,87 @@ sidebar_label: Token authentication admin
 
 ## Token Authentication Overview
 
-Pulsar supports authenticating clients using security tokens that are based on
-[JSON Web Tokens](https://jwt.io/introduction/) 
([RFC-7519](https://tools.ietf.org/html/rfc7519)).
+Pulsar supports authenticating clients using security tokens that are based on 
[JSON Web Tokens](https://jwt.io/introduction/) 
([RFC-7519](https://tools.ietf.org/html/rfc7519)).
 
-Tokens are used to identify a Pulsar client and associate with some 
"principal" (or "role") which
-will be then granted permissions to do some actions (eg: publish or consume 
from a topic).
+You can use tokens to identify a Pulsar client and associate with some 
"principal" (or "role") that
+is permitted to do some actions (for example, publish to a topic or consume 
from a topic).
 
-A user will typically be given a token string by an administrator (or some 
automated service).
+A user typically gets a user a token string from the administrator (or some 
automated service).
 
-The compact representation of a signed JWT is a string that looks like:
+The compact representation of a signed JWT is a string that looks like as the 
follwing:
 
 ```
- 
eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJKb2UifQ.ipevRNuRP6HflG8cFKnmUPtypruRC4fb1DWtoLL62SY
- ```
+eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJKb2UifQ.ipevRNuRP6HflG8cFKnmUPtypruRC4fb1DWtoLL62SY
+```
+
+Application specifies the token when you are creating the client instance. An 
alternative is to pass a "token supplier" (a function that returns the token 
when the client library needs one).
 
-Application will specify the token when creating the client instance. An 
alternative is to pass
-a "token supplier", that is to say a function that returns the token when the 
client library
-will need one.
 
 > #### Always use TLS transport encryption
-> Sending a token is equivalent to sending a password over the wire. It is 
strongly recommended to
-> always use TLS encryption when talking to the Pulsar service. See
-> [Transport Encryption using TLS](security-tls-transport.md)
+> Sending a token is equivalent to sending a password over the wire. You had 
better
+> use TLS encryption all the time when you are talking to the Pulsar service. 
See
+> [Transport Encryption using TLS](security-tls-transport.md) for more details.
 
 ## Secret vs Public/Private keys
 
 JWT support two different kind of keys in order to generate and validate the 
tokens:
 
 Review comment:
   JWT supports...two...kinds...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to