codelipenghui commented on a change in pull request #5227: [PIP-44] Separate
schema compatibility checker for producer and consumer
URL: https://github.com/apache/pulsar/pull/5227#discussion_r333415821
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##########
@@ -164,14 +164,14 @@ void updateRates(NamespaceStats nsStats,
NamespaceBundleStats currentBundleStats
/**
* Check if schema is compatible with current topic schema.
*/
- CompletableFuture<Boolean> isSchemaCompatible(SchemaData schema);
+ CompletableFuture<Void> isSchemaCompatible(SchemaData schema);
Review comment:
Same as above comment, if this method only use for consumer schema
compatible check, it's better to rename to checkSchemaCompatibleForConsumer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
