codelipenghui commented on a change in pull request #5227: [PIP-44] Separate
schema compatibility checker for producer and consumer
URL: https://github.com/apache/pulsar/pull/5227#discussion_r333405829
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -190,12 +191,12 @@ public String getReplicatorPrefix() {
}
@Override
- public CompletableFuture<Boolean> isSchemaCompatible(SchemaData schema) {
+ public CompletableFuture<Void> isSchemaCompatible(SchemaData schema) {
Review comment:
If this method only use for consumer schema compatible check, it's better to
rename to checkSchemaCompatibleForConsumer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
