[GitHub] [pulsar] codelipenghui commented on a change in pull request #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

[GitBox]

codelipenghui commented on a change in pull request #5227: [PIP-44] Separate 
schema compatibility checker for producer and consumer
URL: https://github.com/apache/pulsar/pull/5227#discussion_r333404477
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
 ##########
 @@ -171,7 +172,7 @@ public String getReplicatorPrefix() {
         String id = TopicName.get(base).getSchemaName();
         return brokerService.pulsar()
                 .getSchemaRegistryService()
-                .putSchemaIfAbsent(id, schema, schemaCompatibilityStrategy);
+                .putSchemaIfAbsent(id, schema, schemaCompatibilityStrategy, 
isAllowAutoUpdateSchema);
 
 Review comment:
   Same as above comments, 
   
   ```java
   if(!isAllowAutoUpdateSchema) {
       return FutureUtil.failedFuture(ex);
   } else {
       return 
brokerService.pulsar().getSchemaRegistryService().putSchemaIfAbsent(id, schema, 
schemaCompatibilityStrategy);
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services