merlimat commented on a change in pull request #61: [issue:60] Fix partition
topic message router logic
URL: https://github.com/apache/pulsar-client-go/pull/61#discussion_r342868418
##########
File path: pulsar/impl_producer.go
##########
@@ -45,14 +48,18 @@ func newProducer(client *client, options *ProducerOptions)
(*producer, error) {
return nil, newError(ResultInvalidTopicName, "Topic name is
required for producer")
}
+ if options.BatchingMaxPublishDelay == 0 {
+ options.BatchingMaxPublishDelay = defaultBatchingMaxPublishDelay
+ }
+
p := &producer{
topic: options.Topic,
}
if options.MessageRouter == nil {
internalRouter := internal.NewDefaultRouter(
internal.NewSystemClock(),
- getHashingFunction(options.HashingScheme),
+ getHashingFunction(JavaStringHash),
Review comment:
If a custom message router is not specified, we should use the default
router with the configured hashing scheme.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
