merlimat commented on a change in pull request #61: [issue:60] Fix partition topic message router logic URL: https://github.com/apache/pulsar-client-go/pull/61#discussion_r342731093
########## File path: pulsar/impl_partition_consumer.go ########## @@ -107,7 +109,7 @@ func newPartitionConsumer(client *client, topic string, options *ConsumerOptions log.WithError(err).Errorf("Failed to create consumer") return nil, err } - c.log = c.log.WithField("name", c.consumerName) + c.log = c.log.WithField("consumerID", c.consumerID) Review comment: the consumer name is more meaningful to a user, since it's something the application can set and check on the stats. (also, seems not relevant to this PR). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services