merlimat commented on a change in pull request #61: [issue:60] Fix partition 
topic message router logic
URL: https://github.com/apache/pulsar-client-go/pull/61#discussion_r342730412
 
 

 ##########
 File path: pulsar/impl_consumer.go
 ##########
 @@ -88,7 +87,7 @@ func singleTopicSubscribe(client *client, options 
*ConsumerOptions, topic string
 
        numPartitions := len(partitions)
        c.consumers = make([]Consumer, numPartitions)
-
+       c.queue = make(chan ConsumerMessage, 
options.ReceiverQueueSize*numPartitions)
 
 Review comment:
   This doesn't seem to be related with the partioning router logic. Also, 
there are few issues with the current approach and the way the flow control is 
currently implemented. @cckellogg is preparing a PR for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to