codelipenghui commented on a change in pull request #5570: Transaction log
implemention
URL: https://github.com/apache/pulsar/pull/5570#discussion_r346147104
##########
File path: pulsar-transaction/common/pom.xml
##########
@@ -40,12 +40,22 @@
<artifactId>protobuf-java</artifactId>
<version>${protobuf3.version}</version>
</dependency>
-
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java-util</artifactId>
<version>${protobuf3.version}</version>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>pulsar-common</artifactId>
+ <version>${project.parent.version}</version>
+ </dependency>
Review comment:
is it better to create a proto file in pulsar-transaction-common module? so
that we don't need to add pulsar common dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
