codelipenghui commented on a change in pull request #5570: Transaction log
implemention
URL: https://github.com/apache/pulsar/pull/5570#discussion_r348377382
##########
File path:
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TransactionMetadataStore.java
##########
@@ -58,43 +69,56 @@
* it returns {@link TxnID} as the identifier for identifying the
* transaction.
*/
- CompletableFuture<TxnID> newTransaction();
+ CompletableFuture<TxnID> newTransactionAsync();
/**
- * Add the produced partitions to transaction identified by <tt>txnid</tt>.
+ * Create a new transaction in the transaction metadata store.
*
- * @param txnid transaction id
+ * @param timeOut the timeout time
Review comment:
```suggestion
* @param timeOut the timeout duration of the transaction in mills
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
