codelipenghui commented on a change in pull request #5570: Transaction log
implemention
URL: https://github.com/apache/pulsar/pull/5570#discussion_r346162726
##########
File path:
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TxnMeta.java
##########
@@ -70,6 +79,17 @@
TxnMeta addProducedPartitions(List<String> partitions)
throws InvalidTxnStatusException;
+ /**
+ * Add the list of subscriptions to the transaction.
+ *
+ * @param subscriptions
+ * @return transaction meta
+ * @throws InvalidTxnStatusException if the transaction is not in
+ * {@link TxnStatus#OPEN}
+ */
+ TxnMeta addTxnSubscription(List<TxnSubscription> subscriptions)
Review comment:
Please use `addAckedPartitions`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
