sijie commented on a change in pull request #6052: [PIP-54] Acknowledgement for
batch message local index
URL: https://github.com/apache/pulsar/pull/6052#discussion_r379158699
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
##########
@@ -148,6 +151,10 @@
return position;
};
private final LongPairRangeSet<PositionImpl> individualDeletedMessages;
+
+ // Maintain the indexes deleted status of batch messages that not deleted
completely
+ // (ledgerId, entryId) -> deleted indexes
+ private final ConcurrentSkipListMap<PositionImpl, BitSet>
batchDeletedIndexes;
Review comment:
Same comment as I made to client side change. We should consider re-using
some of the AckSet implementation in bookkeeper client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
