codelipenghui commented on a change in pull request #6183: Namespace level 
offloader
URL: https://github.com/apache/pulsar/pull/6183#discussion_r373751561
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
 ##########
 @@ -785,12 +809,13 @@ public synchronized LedgerOffloader 
createManagedLedgerOffloader(ServiceConfigur
                             
LedgerOffloader.METADATA_SOFTWARE_VERSION_KEY.toLowerCase(), 
PulsarVersion.getVersion(),
                             
LedgerOffloader.METADATA_SOFTWARE_GITSHA_KEY.toLowerCase(), 
PulsarVersion.getGitSha()
                         ),
-                        getOffloaderScheduler(conf));
+                        getOffloaderScheduler(conf),
+                        offloadPolicies);
                 } catch (IOException ioe) {
                     throw new PulsarServerException(ioe.getMessage(), 
ioe.getCause());
                 }
             } else {
-                LOG.info("No ledger offloader configured, using NULL 
instance");
+                LOG.warn("No ledger offloader configured, using NULL 
instance");
 
 Review comment:
   Keep log level to info, we don't need to warn users when they have not 
enable the offloader.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to