codelipenghui commented on a change in pull request #6183: Namespace level 
offloader
URL: https://github.com/apache/pulsar/pull/6183#discussion_r373753135
 
 

 ##########
 File path: 
pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorCache.java
 ##########
 @@ -123,7 +132,7 @@ private synchronized OrderedScheduler 
getOffloaderScheduler(PulsarConnectorConfi
         return this.offloaderScheduler;
     }
 
-    private LedgerOffloader initManagedLedgerOffloader(PulsarConnectorConfig 
conf) {
+    private LedgerOffloader initManagedLedgerOffloader(PulsarConnectorConfig 
conf, OffloadPolicies offloadPolicies) {
 
 Review comment:
   Same as PulsarService, use initManagedLedgerOffloader(OffloadPolicies 
offloadPolicies). For default offloader, just convert serverConfiguration to 
the OffloadPolicies.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to