codelipenghui commented on a change in pull request #6183: Namespace level
offloader
URL: https://github.com/apache/pulsar/pull/6183#discussion_r373753703
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -162,7 +165,8 @@
private ScheduledExecutorService compactorExecutor;
private OrderedScheduler offloaderScheduler;
private Offloaders offloaderManager = new Offloaders();
- private LedgerOffloader offloader;
+ private LedgerOffloader defaultOffloader;
+ private Map<OffloadPolicies, LedgerOffloader> ledgerOffloaderMap = new
ConcurrentHashMap<>();
Review comment:
I'm a little worried about uses OffloadPolicies as a key, because is users
frequently modified the policy, there will be some invalid Offloader objects
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
