sijie commented on a change in pull request #6052: [PIP-54] Acknowledgement for 
batch message local index
URL: https://github.com/apache/pulsar/pull/6052#discussion_r379154256
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -453,6 +454,7 @@ message CommandMessage {
     required uint64 consumer_id       = 1;
     required MessageIdData message_id = 2;
     optional uint32 redelivery_count  = 3 [default = 0];
+    repeated int64 ack_set = 4;
 
 Review comment:
   ```suggestion
       optional int64 ack_set = 4;
   ```
   
   Same question - why do we need `repeatable int64`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to