codelipenghui commented on a change in pull request #6325: KeyValue schema 
support for pulsar sql
URL: https://github.com/apache/pulsar/pull/6325#discussion_r379702123
 
 

 ##########
 File path: 
pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/RawMessage.java
 ##########
 @@ -101,4 +101,19 @@
      * @return the key of the message
      */
     Optional<String> getKey();
+
+    /**
+     * Get byteBuf of the key.
+     *
+     * @return the byte array with the key payload
+     */
+    Optional<ByteBuf> getKeyBytes();
+
+    /**
+     * Check whether the key has been base64 encoded.
+     *
+     * @return true if the key is base64 encoded, false otherwise
+     */
+    boolean hasBase64EncodedKey();
 
 Review comment:
   It's better to named isKeyBase64Encoded().

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to