gaoran10 commented on a change in pull request #6325: KeyValue schema support
for pulsar sql
URL: https://github.com/apache/pulsar/pull/6325#discussion_r379708704
##########
File path:
pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarColumnHandle.java
##########
@@ -58,6 +59,16 @@
private final Integer[] positionIndices;
+ /**
+ * True if the column is key column handler for KeyValueSchema.
+ */
+ private final boolean key;
+
+ /**
+ * True if the column is value column handler for KeyValueSchema.
+ */
+ private final boolean value;
+
Review comment:
I'll use an enum instead to them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
