sijie commented on a change in pull request #6325: KeyValue schema support for
pulsar sql
URL: https://github.com/apache/pulsar/pull/6325#discussion_r379874593
##########
File path:
pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarColumnMetadata.java
##########
@@ -32,15 +33,20 @@
private String nameWithCase;
private String[] fieldNames;
private Integer[] positionIndices;
+ private PulsarColumnHandle.HandleKeyValueType handleKeyValueType;
+ public final static String KEY_SCHEMA_COLUMN_PREFIX = "key.";
+ public final static String VALUE_SCHEMA_COLUMN_PREFIX = "value.";
Review comment:
I don't think we need to add `value.` for value. We should keep the behavior
consistent between messages with keys and without keys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
