murong00 commented on a change in pull request #6574: [Issue 5901] Added
support to offload all partitions of a partitioned topic
URL: https://github.com/apache/pulsar/pull/6574#discussion_r395976976
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -1046,6 +1047,41 @@ public void triggerOffload(
internalTriggerOffload(authoritative, messageId);
}
+ @PUT
+ @Path("/{tenant}/{namespace}/{topic}/partitioned-offload")
Review comment:
I've actually tried to use `offload` whose parameter is `MessageId`, however
there seems to be no way to cast `MessageIdImpl` back to an object that
contains `Map<partition,MessageIdImpl>` at the moment. Maybe we can get rid of
parameter `MessageId` and obtain it within
`PersistentTopicsBase.internalTriggerOffload` but it is an API breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
