murong00 commented on a change in pull request #6574: [Issue 5901] Added 
support to offload all partitions of a partitioned topic
URL: https://github.com/apache/pulsar/pull/6574#discussion_r395980779
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
 ##########
 @@ -1046,6 +1047,41 @@ public void triggerOffload(
         internalTriggerOffload(authoritative, messageId);
     }
 
+    @PUT
+    @Path("/{tenant}/{namespace}/{topic}/partitioned-offload")
 
 Review comment:
   Do you mean all partitions using the same `MessageId`? I am not so sure 
about how to handle the required parameter `sizeThresholdStr` that is used to 
find `MessageId` in a non-partitioned topic (via the result of 
`PersistentTopicInternalStats`). In my opinion, multiple partitioned topics may 
have various `messageId` since the amount of data of each partition are 
different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to