codelipenghui commented on a change in pull request #6574: [Issue 5901] Added 
support to offload all partitions of a partitioned topic
URL: https://github.com/apache/pulsar/pull/6574#discussion_r395978572
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
 ##########
 @@ -1046,6 +1047,41 @@ public void triggerOffload(
         internalTriggerOffload(authoritative, messageId);
     }
 
+    @PUT
+    @Path("/{tenant}/{namespace}/{topic}/partitioned-offload")
 
 Review comment:
   Do we need to reconsider offload by a message ID on a partitioned topic? If 
users need to specify a Map<partition, messageId>, this does not bring 
convenience,  In my opinion, this is more like a bulk API. If a bulk operates,  
topics can across multiple partitioned topics. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to