cornelk opened a new pull request #214: Fix Consumer Seek not returning a potential error URL: https://github.com/apache/pulsar-client-go/pull/214 ### Motivation Review of Consumer Seek() did reveal a potential error that is not returned as such. ### Modifications - refactored `messageID()` to not use a logger but as a helper function that returns an error. It can later be used by a currently missing `Reader` `Seek()` implementation. - return a potential error from `Consumer.Seek()` - log the error in `AckID()` and `NackID()` - changing the interface to return an error for those function should be a better approach ### Verifying this change - [x] Make sure that the change passes the CI checks. This change is already covered by existing tests ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) ### Documentation - Does this pull request introduce a new feature? (no)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
