cckellogg commented on a change in pull request #214: Fix Consumer Seek not
returning a potential error
URL: https://github.com/apache/pulsar-client-go/pull/214#discussion_r408275605
##########
File path: pulsar/impl_message.go
##########
@@ -118,6 +120,24 @@ func newMessageID(ledgerID int64, entryID int64, batchIdx
int, partitionIdx int)
}
}
+// creates a new messageID object from the given MessageID, consumers is the
amount of
+// consumers, 1+ for Consumer, 1 for Reader.
+func newMessageIDFromInterface(msgID MessageID, consumers int) (*messageID,
error) {
Review comment:
The method name is confusing to me something with new should return a new
object. This is just casting it to something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
