cckellogg commented on a change in pull request #214: Fix Consumer Seek not
returning a potential error
URL: https://github.com/apache/pulsar-client-go/pull/214#discussion_r408275588
##########
File path: pulsar/consumer_impl.go
##########
@@ -283,8 +284,9 @@ func (c *consumer) Nack(msg Message) {
}
func (c *consumer) NackID(msgID MessageID) {
- mid, ok := c.messageID(msgID)
- if !ok {
+ mid, err := newMessageIDFromInterface(msgID, len(c.consumers))
Review comment:
Why is that error needed? It looks like it's just being logged and not
returned to the client?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
