gaoran10 commented on a change in pull request #8347:
URL: https://github.com/apache/pulsar/pull/8347#discussion_r511904287
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/InMemTransactionBufferReader.java
##########
@@ -66,15 +66,15 @@ public InMemTransactionBufferReader(TxnID txnId,
Iterator<Entry<Long, ByteBuf>>
int i = 0;
while (i < numEntries && entries.hasNext()) {
Entry<Long, ByteBuf> entry = entries.next();
- TransactionEntry txnEntry = new TransactionEntryImpl(
- txnId,
- entry.getKey(),
- EntryImpl.create(-1L, -1L, entry.getValue()),
- committedAtLedgerId,
- committedAtEntryId,
- -1
- );
- txnEntries.add(txnEntry);
+// TransactionEntry txnEntry = new TransactionEntryImpl(
+// txnId,
+// entry.getKey(),
+// EntryImpl.create(-1L, -1L, entry.getValue()),
+// committedAtLedgerId,
+// committedAtEntryId,
+// -1
+// );
+// txnEntries.add(txnEntry);
Review comment:
The class `TransactionEntryImpl` was removed. The
InMemTransactionBufferReader is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
