gaoran10 commented on a change in pull request #8347:
URL: https://github.com/apache/pulsar/pull/8347#discussion_r511909651
##########
File path: pulsar-common/src/main/proto/PulsarMarkers.proto
##########
@@ -85,5 +85,5 @@ message MessageIdData {
/// --- Transaction marker ---
message TxnCommitMarker {
- required MessageIdData message_id = 1;
+ repeated MessageIdData message_id = 1;
Review comment:
The generated java Api will add suffix `List` after the `messageId`,
just like `getMessageIdList()`, maybe we don't need to add the suffix `s`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
