gaoran10 commented on a change in pull request #8347:
URL: https://github.com/apache/pulsar/pull/8347#discussion_r511912648
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TransactionBufferHandlerImpl.java
##########
@@ -71,13 +75,21 @@ public TransactionBufferHandlerImpl(ConnectionPool
connectionPool, NamespaceServ
}
@Override
- public CompletableFuture<TxnID> endTxnOnTopic(String topic, long
txnIdMostBits, long txnIdLeastBits, PulsarApi.TxnAction action) {
+ public CompletableFuture<TxnID> endTxnOnTopic(String topic, long
txnIdMostBits, long txnIdLeastBits, PulsarApi.TxnAction action, List<MessageId>
messageIdList) {
CompletableFuture<TxnID> cb = new CompletableFuture<>();
if (!canSendRequest(cb)) {
return cb;
}
long requestId = requestIdGenerator.getAndIncrement();
- ByteBuf cmd = Commands.newEndTxnOnPartition(requestId, txnIdLeastBits,
txnIdMostBits, topic, action);
+ List<PulsarApi.MessageIdData> messageIdDataList = new ArrayList<>();
Review comment:
Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
