eolivelli commented on a change in pull request #9286:
URL: https://github.com/apache/pulsar/pull/9286#discussion_r562680344
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##########
@@ -408,7 +408,7 @@ public void initializeFailed(ManagedLedgerException e) {
pendingLedger.ledger.asyncClose(new CloseCallback() {
@Override
public void closeComplete(Object ctx) {
- // no-op
+ log.info("[{}] Closed pending initializer
managed ledger.", name);
Review comment:
probably we want to leave this at `debug` level
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##########
@@ -512,6 +512,7 @@ public void shutdown() throws InterruptedException,
ManagedLedgerException {
ledger.asyncClose(new AsyncCallbacks.CloseCallback() {
@Override
public void closeComplete(Object ctx) {
+ log.info("[{}] Closed managed ledger.", ledger.getName());
Review comment:
probably we want to leave this at `debug` level
##########
File path: pulsar-io/hbase/pom.xml
##########
@@ -70,12 +70,6 @@
<version>${hbase.version}</version>
</dependency>
- <dependency>
Review comment:
this is patch of another patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
