lhotari commented on a change in pull request #9286:
URL: https://github.com/apache/pulsar/pull/9286#discussion_r563630279
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##########
@@ -512,6 +512,7 @@ public void shutdown() throws InterruptedException,
ManagedLedgerException {
ledger.asyncClose(new AsyncCallbacks.CloseCallback() {
@Override
public void closeComplete(Object ctx) {
+ log.debug("[{}] Closed managed ledger.", ledger.getName());
Review comment:
I have removed this change from this PR.
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##########
@@ -542,8 +543,17 @@ public void closeFailed(ManagedLedgerException exception,
Object ctx) {
}
scheduledExecutor.shutdownNow();
- orderedExecutor.shutdownNow();
+ if (!scheduledExecutor.awaitTermination(30, TimeUnit.SECONDS)) {
+ log.error("Cannot stop scheduledExecutor gracefully.");
+ }
+ orderedExecutor.shutdown();
Review comment:
I have removed this change from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
