lhotari commented on a change in pull request #9286:
URL: https://github.com/apache/pulsar/pull/9286#discussion_r563595426
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##########
@@ -207,7 +207,7 @@ public void accept(Notification n) {
@Override
public void close() throws Exception {
- executor.shutdownNow();
+ executor.shutdown();
Review comment:
Thanks for the review @merlimat .
> Why do we need this change?
Valid point. It's not actually needed.
When I was debugging the flakiness, the key issue of the flakiness of
MessageIdTest was related to the restarting of the broker not happening
"cleanly". I started making an experiment where I'd revisit the shutdown of the
broker. However these changes weren't relevant for making the test stable. I'll
remove them completely out of this PR.
The relevant problem in shutdown was in BrokerService where
`listenChannel.close()` doesn't use `.await` to synchronously wait for the
completion of shutting down the listeners. I'll submit that fix as a separate
PR. @sijie suggested in his review comments to split some changes as separate
PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
