codelipenghui commented on a change in pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#discussion_r589835019
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
##########
@@ -18,6 +18,7 @@
*/
package org.apache.pulsar.client.api;
+import io.netty.util.Timer;
Review comment:
Good point!
> Instead, we could take a Timer instance from the PulsarClientImpl
constructor and have the Pulsar proxy to pass it there.
I did not understand here, does this means the PulsarClientImpl exposes the
timer so that the proxy can get the timer and close it? Or we can pass the
Timer through the PulsarClientImpl constructor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
