linlinnn commented on a change in pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#discussion_r595040627
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##########
@@ -131,11 +132,25 @@ public PulsarClientImpl(ClientConfigurationData conf)
throws PulsarClientExcepti
}
public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup
eventLoopGroup) throws PulsarClientException {
- this(conf, eventLoopGroup, new ConnectionPool(conf, eventLoopGroup));
+ this(conf, eventLoopGroup, new ConnectionPool(conf, eventLoopGroup),
null);
}
public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup
eventLoopGroup, ConnectionPool cnxPool)
throws PulsarClientException {
+ this(conf, eventLoopGroup, cnxPool, null);
+ }
+
+ public PulsarClientImpl(ClientConfigurationData conf, Timer timer) throws
PulsarClientException {
Review comment:
> We cannot expose Netty classes on the client API.
> They should construct the PulsarClientImpl, not the ClientBuilder. This is
not a common use, just for some application like Pulsar proxy does.
I add so many new public constructors for being compatible with last
version, any idea for just add the needed ones?
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##########
@@ -131,11 +132,25 @@ public PulsarClientImpl(ClientConfigurationData conf)
throws PulsarClientExcepti
}
public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup
eventLoopGroup) throws PulsarClientException {
- this(conf, eventLoopGroup, new ConnectionPool(conf, eventLoopGroup));
+ this(conf, eventLoopGroup, new ConnectionPool(conf, eventLoopGroup),
null);
}
public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup
eventLoopGroup, ConnectionPool cnxPool)
throws PulsarClientException {
+ this(conf, eventLoopGroup, cnxPool, null);
+ }
+
+ public PulsarClientImpl(ClientConfigurationData conf, Timer timer) throws
PulsarClientException {
Review comment:
> We cannot expose Netty classes on the client API.
> They should construct the PulsarClientImpl, not the ClientBuilder. This is
not a common use, just for some application like Pulsar proxy does.
I add so many new public constructors for being compatible with last
version, any idea for just add the needed ones?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
