BewareMyPower opened a new pull request #9853:
URL: https://github.com/apache/pulsar/pull/9853


   Fixes #7728 
   
   ### Motivation
   
   When a consumer with a schema subscribes a topic without schema, the topic's 
schema should be changed to the consumer's schema even if it's active or has 
existed data.
   
   It should be noted that this change is incompatible with 
[#2669](https://github.com/apache/pulsar/pull/2669). Before this PR, a consumer 
with schema **cannot** attach to a topic without schema.
   
   ### Modifications
   
   - When a consumer subscribes a topic without schema, add schema to the topic 
anyway.
   - Add related tests and remove the incompatible test 
`newConsumerWithSchemaOnExistingTopicWithoutSchema`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change added tests `testAutoCreatedSchema`.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (*yes*)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to