BewareMyPower edited a comment on pull request #9853: URL: https://github.com/apache/pulsar/pull/9853#issuecomment-794627577
@codelipenghui > if the topic has data but does not have a schema I agree, so even if `hasSchema` is false, if `ledger.getTotalSize() != 0`, we should still go to `checkSchemaCompatibleForConsumer`. However, I don't understand why we also need the check of `isActive(InactiveTopicDeleteMode.delete_when_no_subscriptions)`. It causes the failure of `testAutoCreatedSchema` before applying changes of this PR since the topic has no data and it shouldn't fail. Does changing the conditional check to `if (hasSchema || (ledger.getTotalSize() != 0))` have any problem? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
