codelipenghui commented on pull request #9853: URL: https://github.com/apache/pulsar/pull/9853#issuecomment-794646589
> Does changing the conditional check to if (hasSchema || (ledger.getTotalSize() != 0)) have any problem? We need to check if there are producers or consumers connect to this topic. Otherwise, if the old producers and consumers connect with bytes schema, then we change the schema type to `schema.AVRO`, this will break the old producers and consumers. Check no subscriptions is equals to no consumers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
