codelipenghui commented on a change in pull request #11500:
URL: https://github.com/apache/pulsar/pull/11500#discussion_r679329682
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ManagedCursorMetricsTest.java
##########
@@ -90,4 +91,66 @@ public void testManagedCursorMetrics() throws Exception {
Assert.assertEquals(metricsList.get(0).getMetrics().get("brk_ml_cursor_nonContiguousDeletedMessagesRange"),
0L);
}
+ @Test
+ public void testCursorReadWriteMetrics() throws Exception {
+ final String subName = "read-write";
+ final String topicName =
"persistent://my-namespace/use/my-ns/read-write";
+ final int messageSize = 10;
+
+ ManagedCursorMetrics metrics = new ManagedCursorMetrics(pulsar);
+
+ List<Metrics> metricsList = metrics.generate();
+ Assert.assertTrue(metricsList.isEmpty());
+
+ metricsList = metrics.generate();
+ Assert.assertTrue(metricsList.isEmpty());
+
+ @Cleanup
+ Consumer<byte[]> consumer = pulsarClient.newConsumer()
+ .topic(topicName)
+ .subscriptionType(SubscriptionType.Shared)
+ .ackTimeout(1, TimeUnit.SECONDS)
+ .subscriptionName(subName)
+ .subscribe();
+
+ @Cleanup
+ Consumer<byte[]> consumer2 = pulsarClient.newConsumer()
+ .topic(topicName)
+ .subscriptionType(SubscriptionType.Shared)
+ .ackTimeout(1, TimeUnit.SECONDS)
+ .subscriptionName(subName + "-2")
+ .subscribe();
+
+ @Cleanup
+ Producer<byte[]> producer = pulsarClient.newProducer()
+ .topic(topicName)
+ .create();
+
+ for (PulsarMockLedgerHandle ledgerHandle :
mockBookKeeper.getLedgerMap().values()) {
+ ledgerHandle.close();
+ }
+
+ for (int i = 0; i < messageSize; i++) {
+ String message = "my-message-" + i;
+ producer.send(message.getBytes());
+ if (i % 2 == 0) {
+ consumer.acknowledge(consumer.receive().getMessageId());
+ } else {
+ consumer2.acknowledge(consumer.receive().getMessageId());
+ }
+ }
+ metricsList = metrics.generate();
+ Assert.assertEquals(metricsList.size(), 3);
+
Assert.assertEquals(metricsList.get(0).getMetrics().get("brk_ml_cursor_writeLedgerSize"),
26L);
Review comment:
Will the size be changed when running the test multiple times? If yes, I
think we can just check if the size > 0 or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
